Split javascript interface methods into domain objects. #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhongqiliang
commented
Oct 21, 2024
zhongqiliang
commented
- Create a new interface class JavaScriptAndroidObject.java, moved platformservice javascript interface methods into an implementation of it.
- Moved user agent string related code to a separate util class.
- Move system property methods to util.
- Split ChrobaltWebViewClient into a separate file.
- Moved h5vcc platform service js code into platform_services.js.
Change-Id: I8c9af486c107377d16316361b12be4db3d47dd17
Build Status
|
kaidokert
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.