Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split javascript interface methods into domain objects. #4289

Closed
wants to merge 1 commit into from
Closed

Split javascript interface methods into domain objects. #4289

wants to merge 1 commit into from

Conversation

zhongqiliang
Copy link
Contributor

@zhongqiliang zhongqiliang commented Oct 21, 2024 •
edited
Loading

Some refactors.

  1. Create a new interface class WebAppInterface, moved platformservice javascript interface methods into an implementation of it.
  2. Moved user agent string related code to a separate util class.
  3. Move system property methods to util.

Change-Id: I7f43808a579e7740b23a2c154e8395e8c85cf9b4

Split javascript interface methods into domain objects.
34d9942 
Change-Id: I7f43808a579e7740b23a2c154e8395e8c85cf9b4
@github-actions GitHub Actions
Copy link

Build Status

Workflow Status
lint lint
android android
evergreen evergreen
linux linux
raspi-2 raspi-2
stub stub
win32 win32

kaidokert
kaidokert reviewed Oct 21, 2024
View reviewed changes
starboard/android/apk/app/src/main/java/dev/cobalt/util/SystemPropertiesHelper.java
@@ -1,51 +1,55 @@
// Copyright 2017 The Cobalt Authors. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete the copyright please :)

kaidokert
kaidokert approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup

@kaidokert kaidokert deleted the colin_refactor branch October 21, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhongqiliang @kaidokert