Add event config for starboard

[MSoliankoLuxoft]

b/372056053

[niranjanyardi]

With this change in, can you build PS5 locally ? @MSoliankoLuxoft

@kaidokert , @andrewsavage1 :
I'm a bit worried that this will affect other platforms unintentionally.
Also this seems to be a newly needed change just for PS5 as we updated the SDK to SDK10 .
In the pre-chrobalt repo it's not there: https://paste.googleplex.com/6574054365724672

Maybe a good way to handle this is to introduce a macro USE_STARBOARD_3P - which is set by 3P owners instead of our USE_STARBOARD or maybe there's a better way to handle this . wdyt ?

[andrewsavage1]

@kaidokert , @andrewsavage1 : I'm a bit worried that this will affect other platforms unintentionally. Also this seems to be a newly needed change just for PS5 as we updated the SDK to SDK10 . In the pre-chrobalt repo it's not there: paste.googleplex.com/6574054365724672

Maybe a good way to handle this is to introduce a macro USE_STARBOARD_3P - which is set by 3P owners instead of our USE_STARBOARD or maybe there's a better way to handle this . wdyt ?

I don't think we should be accepting this kind of change at al unless it ends up being necessary for evergreen builds. Pretty much all customizations for 3pp should be maintained downstream

[niranjanyardi]

@MSoliankoLuxoft can you somehow fix this via setting buildflags/ defines in GN in the PS5 gn files ? not these common files.

[kaidokert]

My recommendation:

In PS5 port, create a directory

internal/third_party/libevent - put this modified file there. add internal/ to root include paths.

Then make sure that this added internal include path comes before the other include paths - so that compiler always finds it before this file.

[MSoliankoLuxoft]

My recommendation:

In PS5 port, create a directory

internal/third_party/libevent - put this modified file there. add internal/ to root include paths.

Then make sure that this added internal include path comes before the other include paths - so that compiler always finds it before this file.

Unfortunately, the proposed approach does not work because the event-config.h file, which I want to override in the PS5 build, is included as "event-config.h". When I change the path to my custom directory in the PS5 GN file, it doesn’t work because it will always take the local version of event-config.h located in third_party/libevent. For it to work, the inclusion would need to change from "" to <event-config.h>, but unfortunately, such changes would break most builds.

I also tried using the following define in the PS5 GN file: defines=["event-config.h=third_party/libevent/starboard/event-config.h"], but it didn’t work because there is a - character in event-config.h.

I decided to use an alternative approach, similar to what is used in epoll.c with the LIBEVENT_PLATFORM_HEADER define, which for PS5 is defined in internal\starboard\shared\playstation\configuration_public.h and specifies the necessary path for the correct include.

Please let me know if this approach would be acceptable.

[kaidokert]

This is a better approach, but maybe this block fits better inside of the "event-config.h" at the top before the other conditions ?

That change could even be sent to upstream and be accepted, i think ?

[kaidokert]

For what it's worth, it's not really an upstreaming concern for us much longer, Chromium removed libevent entirely: https://issues.chromium.org/issues/40057013