[android] Fix incorrect JNI call on MediaCodecBridge #4218
Merged
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
fix_android_flush_restart
branch
2 times, most recently
from
e679f9f to
710e5fe
Compare
borongc
force-pushed
the
fix_android_flush_restart
branch
from
710e5fe to
ebedae6
Compare
osagie98
approved these changes
Nov 19, 2024
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Outdated
Show resolved
Hide resolved
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Show resolved
Hide resolved
at-ninja
approved these changes
Nov 20, 2024
borongc
force-pushed
the
fix_android_flush_restart
branch
from
ebedae6 to
5489258
Compare
borongc
force-pushed
the
fix_android_flush_restart
branch
from
5489258 to
197deab
Compare
This is the same PR as youtube#4112. Original commit message: Fix incorrect JNI call on MediaCodecBridge start(). A new argument CreateMediaCodecBridgeResult was added in [PR 3672](youtube#3672). However, the corresponding JNI call didn't change, which could cause native crash by player_worker. b/366746149 b/320568573 b/364415911
borongc
force-pushed
the
fix_android_flush_restart
branch
from
197deab to
9207299
Compare
osagie98
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #4112.
Original commit message:
Fix incorrect JNI call on MediaCodecBridge start(). A new argument CreateMediaCodecBridgeResult was added in PR 3672. However, the corresponding JNI call didn't change, which could cause native crash by player_worker.
b/366746149
b/320568573
b/364415911