starboard/types.h: Replace kSbInt32Max with std::numeric_limits equivalents #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…INT32_MIN where appropriate (C headers/files).
Datadog ReportBranch report: ✅ 0 Failed, 228913 Passed, 42 Skipped, 38m 16.37s Total Time |
|
@madhurajayaraman PTAL |
madhurajayaraman
approved these changes
Oct 2, 2024
|
Can you run on-device tests? (Right sidebar, add the label "on_device" and it should automatically kick off the tests) |
|
Thanks @oxve ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said this CL replaces kSbInt16Max with its std::numeric_limits<> equivalent, removes kSbInt32Min and kSbUInt32Max because they're unused, and uses the stdint.h INT32_MIN where appropriate (for kSbInvalidInt and in a C header file).
Verified via local x64x11 build.
[1] https://source.corp.google.com/search?q=kSb.%3FInt(32)&sq=&ss=h%2Flbshell-internal%2Fcobalt_src%2F%2B%2Frefs%2Fheads%2FCOBALT
b/366064934