Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard/types.h: Remove some unused types #4168

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

yell0wd0g
Copy link
Contributor

As said, kSb(U)Int8(Min|Max) are not used anywhere [1]. This CL removes them. Verified bya local x64x11 build.

[1] https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:starboard/types.h?q=kSb.%3FInt(8)&ss=h%2Flbshell-internal%2Fcobalt_src%2F%2B%2Frefs%2Fheads%2FCOBALT

b/366064934

@yell0wd0g
Copy link
Contributor Author

@y4vor PTAL - I thought this could be the smallest/trivial-est CL ever.

(For the other types, they can be replaced in this file with e.g.
std::numeric_limits<Bla>::min()/max() etc, or the substitutions
can be done at use/callsites. No need to decide here and now :)

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Sep 27, 2024

Datadog Report

Branch report: b_366064934__A__remove_unused_type_limits
Commit report: a824a7e
Test service: cobalt

✅ 0 Failed, 33731 Passed, 6 Skipped, 7m 23.81s Total Time

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (0faa42d) to head (3a76d91).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4168      +/-   ##
==========================================
+ Coverage   57.48%   57.49%   +0.01%     
==========================================
  Files        1742     1742              
  Lines       86343    86330      -13     
==========================================
+ Hits        49632    49638       +6     
+ Misses      36711    36692      -19     
Flag Coverage Δ
57.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yell0wd0g yell0wd0g assigned yell0wd0g and unassigned y4vor Sep 27, 2024
@yell0wd0g yell0wd0g force-pushed the b_366064934__A__remove_unused_type_limits branch from 3a76d91 to a824a7e Compare September 30, 2024 19:44
@yell0wd0g yell0wd0g merged commit 06c3271 into main Sep 30, 2024
230 of 231 checks passed
@yell0wd0g yell0wd0g deleted the b_366064934__A__remove_unused_type_limits branch September 30, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants