Fix wpt tests on gcc-6-3 and clang-3-9 builds #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherryzy
force-pushed
the
fix_gcc_clang_builds
branch
2 times, most recently
from
7630dc0
to
5045e21
Compare
sherryzy
force-pushed
the
fix_gcc_clang_builds
branch
2 times, most recently
from
daa40a8
to
0856184
Compare
The timeout value is around the same as web platform test time out value. In most builds, it will trigger wpt timeout first, and everything works expected. For gcc and clang builds, maybe it runs slower, and it trigger taskEnviroment timeout first. Slightly increase the timeout value will resolve the issue. b/336564460
sherryzy
force-pushed
the
fix_gcc_clang_builds
branch
from
0856184
to
7fda248
Compare
johnxwork
approved these changes
May 15, 2024
jellefoks
approved these changes
May 15, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
May 15, 2024
The timeout value is around the same as web platform test time out value. In most builds, it will trigger wpt timeout first, and everything works expected. For gcc and clang builds, these three tests trigger taskEnvironment timeout first. Slightly increase the timeout value for taskEnvironment or decrease the timeout value for wpt seems resolve the issue. b/336564460 (cherry picked from commit fb13179)
sherryzy
added a commit
that referenced
this pull request
May 15, 2024
…3254) Refer to the original PR: #3131 The timeout value is around the same as web platform test time out value. In most builds, it will trigger wpt timeout first, and everything works expected. For gcc and clang builds, these three tests trigger taskEnvironment timeout first. Slightly increase the timeout value for taskEnvironment or decrease the timeout value for wpt seems resolve the issue. b/336564460 Co-authored-by: Sherry Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout value is around the same as web platform test time out
value. In most builds, it will trigger wpt timeout first, and
everything works expected. For gcc and clang builds, these three tests trigger taskEnvironment timeout first. Slightly
increase the timeout value for taskEnvironment or decrease the timeout value for wpt seems resolve the issue.
b/336564460