Skip to content

Commit

Permalink
Fix wpt tests on gcc-6-3 and clang-3-9 builds (#3131)
Browse files Browse the repository at this point in the history
The timeout value is around the same as web platform test time out
value. In most builds, it will trigger wpt timeout first, and
everything works expected. For gcc and clang builds, these three tests
trigger taskEnvironment timeout first. Slightly
increase the timeout value for taskEnvironment or decrease the timeout
value for wpt seems resolve the issue.

b/336564460

(cherry picked from commit fb13179)
  • Loading branch information
sherryzy authored and anonymous1-me committed May 15, 2024
1 parent d39c00a commit 1e75c5d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 33 deletions.
16 changes: 0 additions & 16 deletions starboard/linux/x64x11/clang/3.9/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,6 @@ def GetTestFilters(self):
filters.extend(test_filter.TestFilter(target, test) for test in tests)
return filters

def GetWebPlatformTestFilters(self):
filters = super().GetWebPlatformTestFilters()
for target, tests in self.__FILTERED_WPT_TESTS.items():
filters.extend(test_filter.TestFilter(target, test) for test in tests)
return filters

# pylint: disable=line-too-long
__FILTERED_WPT_TESTS = { # pylint: disable=invalid-name
'web_platform_tests': [
# TODO(b/332367155): Re-enable web_platform_tests once fixed.
'xhr/WebPlatformTest.Run/XMLHttpRequest_send_sync_blocks_async_htm',
'dom/WebPlatformTest.Run/dom_nodes_MutationObserver_attributes_html',
'html/WebPlatformTest.Run/html_dom_documents_dom_tree_accessors_Document_currentScript_sub_html',
],
}

# A map of failing or crashing tests per target.
__FILTERED_TESTS = { # pylint: disable=invalid-name
'base_unittests': [
Expand Down
16 changes: 0 additions & 16 deletions starboard/linux/x64x11/gcc/6.3/cobalt/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,6 @@ def GetTestFilters(self):
filters.extend(test_filter.TestFilter(target, test) for test in tests)
return filters

def GetWebPlatformTestFilters(self):
filters = super().GetWebPlatformTestFilters()
for target, tests in self.__FILTERED_WPT_TESTS.items():
filters.extend(test_filter.TestFilter(target, test) for test in tests)
return filters

# pylint: disable=line-too-long
__FILTERED_WPT_TESTS = { # pylint: disable=invalid-name
'web_platform_tests': [
# TODO(b/332367155): Re-enable web_platform_tests once fixed.
'xhr/WebPlatformTest.Run/XMLHttpRequest_send_sync_blocks_async_htm',
'dom/WebPlatformTest.Run/dom_nodes_MutationObserver_attributes_html',
'html/WebPlatformTest.Run/html_dom_documents_dom_tree_accessors_Document_currentScript_sub_html',
],
}

# A map of failing or crashing tests per target.
__FILTERED_TESTS = { # pylint: disable=invalid-name
'base_unittests': [
Expand Down
2 changes: 1 addition & 1 deletion third_party/web_platform_tests/resources/testharness.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ policies and contribution forms [3].
var settings = {
output:true,
harness_timeout:{
"normal":10000,
"normal":9000,
"long":60000
},
test_timeout:null,
Expand Down

0 comments on commit 1e75c5d

Please sign in to comment.