Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable base tracing #3068

Merged
merged 9 commits into from
May 15, 2024
Merged

Conversation

andrewsavage1
Copy link
Contributor

@andrewsavage1 andrewsavage1 commented Apr 24, 2024

b/330561515

Test-On-Device: true

@andrewsavage1 andrewsavage1 force-pushed the feature/perfetto branch 3 times, most recently from 0f94bba to 49685ff Compare May 2, 2024 16:10
@andrewsavage1 andrewsavage1 force-pushed the feature/perfetto branch 7 times, most recently from a2c3ff8 to 96b4d38 Compare May 7, 2024 18:31
@andrewsavage1
Copy link
Contributor Author

@jellefoks FYI I created b/339293015 to follow up on flaky behavior with traces from devtools

@andrewsavage1 andrewsavage1 marked this pull request as ready for review May 7, 2024 22:10
@andrewsavage1
Copy link
Contributor Author

Note that I would recommend reviewing this commit by commit, as ac1bc38 (#3068) just adds upstream 3p files as is.

third_party/perfetto/buildtools/sqlite/sqlite3.c Outdated Show resolved Hide resolved
third_party/perfetto/buildtools/BUILD.gn Outdated Show resolved Hide resolved
third_party/perfetto/buildtools/sqlite/sqlite3.c Outdated Show resolved Hide resolved
third_party/perfetto/buildtools/sqlite/sqlite3.c Outdated Show resolved Hide resolved
third_party/perfetto/buildtools/sqlite/sqlite3.c Outdated Show resolved Hide resolved
third_party/perfetto/src/base/temp_file.cc Outdated Show resolved Hide resolved
third_party/perfetto/src/base/temp_file.cc Outdated Show resolved Hide resolved
third_party/perfetto/src/base/unix_task_runner.cc Outdated Show resolved Hide resolved
base/BUILD.gn Outdated Show resolved Hide resolved
Copy link
Contributor

@johnxwork johnxwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@andrewsavage1 andrewsavage1 merged commit 250bb49 into youtube:main May 15, 2024
336 of 350 checks passed
@andrewsavage1 andrewsavage1 deleted the feature/perfetto branch May 15, 2024 17:48
@andrewsavage1 andrewsavage1 added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label May 15, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request May 15, 2024
b/330561515

(cherry picked from commit 250bb49)
andrewsavage1 added a commit that referenced this pull request May 15, 2024
b/330561515

(cherry picked from commit 250bb49)
andrewsavage1 added a commit that referenced this pull request May 16, 2024
b/330561515

(cherry picked from commit 250bb49)
andrewsavage1 added a commit that referenced this pull request May 16, 2024
Refer to the original PR: #3068

b/330561515

Co-authored-by: Andrew Savage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch on_device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants