refactor: useDropDown() 훅을 Radix UI의 Popover 컴포넌트로 리팩토링 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owl1753
approved these changes
Feb 6, 2025
|
스크롤 되는게 이 프로젝트 웹뷰 환경에서 괜찮은 경험일지 확인만 부탁드려요 |
오 지금 확인해보니 아래로 펼쳐질 충분한 공간이 없으면 위로 펼쳐지네요. Radix UI에서 알아서 처리를 해주는 것 같네요. |
엄.. 일단 디자인 나온대로 구현한거라 배포한다음 테스트를 해보는게 좋을 것 같네요 |
|
배포한 다음 테스트하는거보다 그냥 바로 디자인팀에 넛지 날리는게 더 리소스 적게들 수 있어요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
useDropDown()훅을 Radix UI의Popover컴포넌트로 리팩토링 했습니다.Popover컴포넌트는 AppScreen's height calculated as 0 when used with Radix UI Dropdown Menu daangn/stackflow#570 에서 언급한document.body에position: relative를 추가하는 동작이 없어서 액티비티가 정상적으로 잘 보이는 것 같습니다Popover컴포넌트로 교체하니 키보드 네비게이션도 사용할 수 있어서 좋네요👍2025-02-06.4.09.20.mov