Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 로깅 개선사항 건의, 수정 #3

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: 로깅 개선사항 건의, 수정 #3

merged 2 commits into from
Jan 17, 2024

Conversation

eckrin
Copy link
Member

@eckrin eckrin commented Jan 17, 2024 •
edited
Loading

개선 요청결과 반영

description

  1. es에 클라이언트의 실제 action에 대한 timestamp 저장
  2. save 요청시 저장된 데이터에 대한 정보 반환
  3. rest api 요청방식 수정
  4. Assembler에 companion object 대신 object class 적용
  5. 네이밍 규칙 관습따라 수정
  6. ResponseDto에 string message필드 삭제

shon5544
shon5544 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@shon5544 shon5544 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍

@eckrin eckrin merged commit 43a45b4 into master Jan 17, 2024
@shon5544 shon5544 deleted the feat/init-supplement branch January 17, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shon5544 shon5544 shon5544 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eckrin @shon5544