chore(lint): migrate to xo

.vscode/settings.json

@@ -4,6 +4,14 @@
   },
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.formatOnSave": true,
+  "xo.enable": true,
+  "xo.format.enable": true,
+  "[javascript]": {
+    "editor.defaultFormatter": "samverschueren.linter-xo"
+  },
+  "[typescript]": {
+    "editor.defaultFormatter": "samverschueren.linter-xo"
+  },
   "typescript.tsdk": "node_modules/typescript/lib",
   "prettier.ignorePath": "./node_modules/@younho9/prettier-config/.prettierignore"
 }

babel.config.cjs

@@ -1,4 +1,6 @@
-const BABEL_ENV = process.env.BABEL_ENV;
+const {env} = require('process');
+
+const {BABEL_ENV} = env;
 const isCJS = BABEL_ENV !== undefined && BABEL_ENV === 'cjs';
 const isESM = BABEL_ENV !== undefined && BABEL_ENV === 'esm';
 

package.json

@@ -24,11 +24,7 @@
     "git:commit-msg": "commitlint --edit",
     "git:install-hooks": "husky install",
     "git:pre-commit": "lint-staged",
-    "lint": "yarn lint:pkgs",
-    "lint:pkgs": "lerna run lint --no-private --stream",
-    "lint:root": "eslint *.cjs",
-    "lint:src": "lerna run lint:src --no-private --stream",
-    "lint:types": "lerna run lint:types --no-private --stream",
+    "lint": "xo",
     "pkgs": "manypkg run",
     "pkgs:check": "manypkg check",
     "pkgs:fix": "manypkg fix",
@@ -43,12 +39,18 @@
       "prettier --write --ignore-path ./node_modules/@younho9/prettier-config/.prettierignore"
     ],
     "*.{js,jsx,ts,tsx}": [
-      "eslint --fix"
+      "xo"
     ],
     "package.json": [
       "sort-package-json"
     ]
   },
+  "xo": {
+    "parserOptions": {
+      "project": "./tsconfig.xo.json"
+    },
+    "prettier": true
+  },
   "prettier": "@younho9/prettier-config",
   "dependencies": {
     "@babel/cli": "^7.15.4",
@@ -72,20 +74,6 @@
     "@younho9/tsconfig": "0.1.1",
     "concurrently": "6.2.1",
     "cross-env": "^7.0.3",
-    "eslint": "^7.32.0",
-    "eslint-config-prettier": "^8.3.0",
-    "eslint-import-resolver-node": "0.3.6",
-    "eslint-import-resolver-typescript": "2.5.0",
-    "eslint-plugin-import": "2.24.2",
-    "eslint-plugin-jest": "24.5.2",
-    "eslint-plugin-jsdoc": "36.1.0",
-    "eslint-plugin-jsx-a11y": "6.4.1",
-    "eslint-plugin-node": "11.1.0",
-    "eslint-plugin-prettier": "4.0.0",
-    "eslint-plugin-react": "7.25.1",
-    "eslint-plugin-react-hooks": "4.2.0",
-    "eslint-plugin-tsdoc": "0.2.14",
-    "eslint-plugin-unicorn": "36.0.0",
     "husky": "^7.0.1",
     "jest": "27.2.0",
     "lerna": "^4.0.0",
@@ -97,7 +85,8 @@
     "ts-node": "10.2.1",
     "tsd": "0.18.0",
     "typedoc": "0.22.6",
-    "typescript": "^4.4.3"
+    "typescript": "^4.4.3",
+    "xo": "0.46.3"
   },
   "engines": {
     "node": "^12.20.0 || ^14.13.1 || >=16.0.0"

packages/babel-preset/package.json

@@ -29,9 +29,7 @@
     "build": "concurrently yarn:build:*",
     "build:cjs": "babel src -d dist --source-maps",
     "clean": "concurrently yarn:clean:*",
-    "clean:dist": "rimraf dist",
-    "lint": "concurrently yarn:lint:*",
-    "lint:src": "eslint src --ext .js,.jsx,.ts,.tsx"
+    "clean:dist": "rimraf dist"
   },
   "babel": {
     "presets": [

packages/babel-preset/src/index.js → packages/babel-preset/src/index.cjs

@@ -1,7 +1,7 @@
 import {declare} from '@babel/helper-plugin-utils';
 
 /** @type {import("@types/babel__helper-plugin-utils").declare } */
-export default declare((api, opts) => {
+export default declare((api, options) => {
   api.assertVersion(7);
 
   const {
@@ -11,7 +11,7 @@ export default declare((api, opts) => {
     isCJS = false,
     isESM = false,
     addModuleExports = false,
-  } = opts;
+  } = options;
 
   const config = {
     presets: [

packages/eslint-plugin/package.json

@@ -41,10 +41,7 @@
     "build:cjs": "babel src --extensions .ts,.tsx -d dist --source-maps",
     "build:types": "tsc src/*.ts --emitDeclarationOnly --declaration --declarationDir dist/types",
     "clean": "concurrently yarn:clean:*",
-    "clean:dist": "rimraf dist",
-    "lint": "concurrently yarn:lint:*",
-    "lint:src": "eslint src --ext .js,.jsx,.ts,.tsx",
-    "lint:types": "tsc --noEmit"
+    "clean:dist": "rimraf dist"
   },
   "dependencies": {
     "@types/eslint": "7.28.0"

packages/eslint-plugin/src/configs/javascript.ts

@@ -1,10 +1,12 @@
 import type {Linter} from 'eslint';
 
-export default {
+const javascript: Linter.Config = {
   extends: ['plugin:jsdoc/recommended'],
   settings: {
     jsdoc: {
       mode: 'typescript',
     },
   },
-} as Linter.Config;
+};
+
+export default javascript;

packages/eslint-plugin/src/configs/jest.ts

@@ -1,8 +1,10 @@
 import type {Linter} from 'eslint';
 
-export default {
+const jest: Linter.Config = {
   env: {
     jest: true,
   },
   extends: ['plugin:jest/recommended', 'plugin:jest/style'],
-} as Linter.Config;
+};
+
+export default jest;

packages/eslint-plugin/src/configs/react.ts

@@ -1,6 +1,6 @@
 import type {Linter} from 'eslint';
 
-export default {
+const react: Linter.Config = {
   parserOptions: {
     ecmaFeatures: {
       jsx: true,
@@ -16,4 +16,6 @@ export default {
       version: 'detect',
     },
   },
-} as Linter.Config;
+};
+
+export default react;

packages/eslint-plugin/src/configs/recommended.ts

@@ -4,7 +4,7 @@ import {IMPORT_RULES, UNICORN_RULES} from './rules/index.js';
 
 const ignorePatterns = ['**/dist/*'];
 
-export default {
+const recommended: Linter.Config = {
   ignorePatterns,
   parserOptions: {
     ecmaVersion: 2021,
@@ -52,4 +52,6 @@ export default {
       extends: ['plugin:@younho9/jest'],
     },
   ],
-} as Linter.Config;
+};
+
+export default recommended;

packages/eslint-plugin/src/configs/rules/import.ts

@@ -1,8 +1,9 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 import type {Linter} from 'eslint';
 
 import {WARN} from '../../constants/index.js';
 
-export default {
+const IMPORT_RULES: Linter.RulesRecord = {
   'import/order': [
     WARN,
     {
@@ -13,4 +14,6 @@ export default {
       },
     },
   ],
-} as Linter.RulesRecord;
+};
+
+export default IMPORT_RULES;

packages/eslint-plugin/src/configs/rules/node.ts

@@ -1,10 +1,13 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 import type {Linter} from 'eslint';
 
 import {OFF} from '../../constants/index.js';
 
-export default {
+const NODE_RULES: Linter.RulesRecord = {
   'node/no-missing-import': OFF,
   'node/no-missing-require': OFF,
   'node/no-extraneous-import': OFF,
   'node/no-extraneous-require': OFF,
-} as Linter.RulesRecord;
+};
+
+export default NODE_RULES;

packages/eslint-plugin/src/configs/rules/tsdoc.ts

@@ -1,7 +1,10 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 import type {Linter} from 'eslint';
 
 import {WARN} from '../../constants/index.js';
 
-export default {
+const TSDOC_RULES: Linter.RulesRecord = {
   'tsdoc/syntax': WARN,
-} as Linter.RulesRecord;
+};
+
+export default TSDOC_RULES;

packages/eslint-plugin/src/configs/rules/unicorn.ts

@@ -1,7 +1,10 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 import type {Linter} from 'eslint';
 
 import {ERROR} from '../../constants/index.js';
 
-export default {
+const UNICORN_RULES: Linter.RulesRecord = {
   'unicorn/prefer-module': ERROR,
-} as Linter.RulesRecord;
+};
+
+export default UNICORN_RULES;

packages/eslint-plugin/src/configs/typescript.ts

@@ -2,7 +2,7 @@ import type {Linter} from 'eslint';
 
 import {NODE_RULES, TSDOC_RULES} from './rules/index.js';
 
-export default {
+const typescript: Linter.Config = {
   parser: '@typescript-eslint/parser',
   plugins: ['eslint-plugin-tsdoc'],
   extends: [
@@ -14,4 +14,6 @@ export default {
     ...NODE_RULES,
     ...TSDOC_RULES,
   },
-} as Linter.Config;
+};
+
+export default typescript;

packages/eslint-plugin/src/constants/rule-values.ts

@@ -1,6 +1,7 @@
+/* eslint-disable @typescript-eslint/naming-convention */
 /**
  * {@link https://eslint.org/docs/user-guide/configuring/rules#configuring-rules}
  */
-export const OFF = 0;
-export const WARN = 1;
-export const ERROR = 2;
+export const OFF = 0 as const;
+export const WARN = 1 as const;
+export const ERROR = 2 as const;

packages/eslint-plugin/src/index.ts

@@ -1,5 +1,7 @@
 import * as configs from './configs/index.js';
 
-export default {
+const eslintPlugin = {
   configs,
 };
+
+export default eslintPlugin;

packages/guards/__tests__/isFalsy.test.ts → packages/guards/__tests__/is-falsy.test.ts

@@ -13,7 +13,7 @@ describe('isFalsy', () => {
     expect(isFalsy(``)).toBeTruthy();
     expect(isFalsy(null)).toBeTruthy();
     expect(isFalsy(undefined)).toBeTruthy();
-    expect(isFalsy(NaN)).toBeTruthy();
+    expect(isFalsy(Number.NaN)).toBeTruthy();
     expect(isFalsy(document.all)).toBeTruthy();
   });
 
@@ -29,7 +29,7 @@ describe('isFalsy', () => {
     expect(isFalsy(12n)).toBeFalsy();
     expect(isFalsy(3.14)).toBeFalsy();
     expect(isFalsy(-3.14)).toBeFalsy();
-    expect(isFalsy(Infinity)).toBeFalsy();
-    expect(isFalsy(-Infinity)).toBeFalsy();
+    expect(isFalsy(Number.POSITIVE_INFINITY)).toBeFalsy();
+    expect(isFalsy(Number.NEGATIVE_INFINITY)).toBeFalsy();
   });
 });

packages/guards/__tests__/isNullish.test.ts → packages/guards/__tests__/is-nullish.test.ts

@@ -18,7 +18,7 @@ describe('isNullish', () => {
     expect(isNullish(12n)).toBeFalsy();
     expect(isNullish(3.14)).toBeFalsy();
     expect(isNullish(-3.14)).toBeFalsy();
-    expect(isNullish(Infinity)).toBeFalsy();
-    expect(isNullish(-Infinity)).toBeFalsy();
+    expect(isNullish(Number.POSITIVE_INFINITY)).toBeFalsy();
+    expect(isNullish(Number.NEGATIVE_INFINITY)).toBeFalsy();
   });
 });

packages/guards/__tests__/isTruthy.test.ts → packages/guards/__tests__/is-truthy.test.ts

@@ -13,7 +13,7 @@ describe('isTruthy', () => {
     expect(isTruthy(``)).toBeFalsy();
     expect(isTruthy(null)).toBeFalsy();
     expect(isTruthy(undefined)).toBeFalsy();
-    expect(isTruthy(NaN)).toBeFalsy();
+    expect(isTruthy(Number.NaN)).toBeFalsy();
     expect(isTruthy(document.all)).toBeFalsy();
   });
 
@@ -29,7 +29,7 @@ describe('isTruthy', () => {
     expect(isTruthy(12n)).toBeTruthy();
     expect(isTruthy(3.14)).toBeTruthy();
     expect(isTruthy(-3.14)).toBeTruthy();
-    expect(isTruthy(Infinity)).toBeTruthy();
-    expect(isTruthy(-Infinity)).toBeTruthy();
+    expect(isTruthy(Number.POSITIVE_INFINITY)).toBeTruthy();
+    expect(isTruthy(Number.NEGATIVE_INFINITY)).toBeTruthy();
   });
 });

packages/guards/package.json

@@ -33,9 +33,6 @@
     "build:types": "tsc src/*.ts --emitDeclarationOnly --declaration --declarationDir dist/types",
     "clean": "concurrently yarn:clean:*",
     "clean:dist": "rimraf dist",
-    "lint": "concurrently yarn:lint:*",
-    "lint:src": "eslint src --ext .js,.jsx,.ts,.tsx",
-    "lint:types": "tsc --noEmit",
     "test": "concurrently yarn:test:*",
     "test:src": "jest --config ../../jest.config.cjs -- packages/guards"
   },

packages/guards/src/index.ts

@@ -1,5 +1,5 @@
-export {default as isFalsy} from './isFalsy.js';
-export {default as isKeyOf} from './isKeyOf.js';
-export {default as isNullish} from './isNullish.js';
-export {default as isTruthy} from './isTruthy.js';
+export {default as isFalsy} from './is-falsy.js';
+export {default as isKeyOf} from './is-key-of.js';
+export {default as isNullish} from './is-nullish.js';
+export {default as isTruthy} from './is-truthy.js';
 export * from '@sniptt/guards';

packages/guards/src/is-key-of.ts

@@ -0,0 +1,5 @@
+export default function isKeyOf<
+  T extends object, // eslint-disable-line @typescript-eslint/ban-types
+>(object: T) {
+  return (key: PropertyKey): key is keyof T => key in object;
+}

packages/guards/src/isTruthy.ts → packages/guards/src/is-truthy.ts

@@ -1,6 +1,6 @@
 import type {Falsy, Truthy} from '@younho9/types';
 
-import isFalsy from './isFalsy.js';
+import isFalsy from './is-falsy.js';
 
 export default function isTruthy<T>(
   condition: T | Falsy,