Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.4.0 #2880

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Prepare for v0.4.0 #2880

merged 1 commit into from
Aug 23, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Aug 15, 2024

ref: #2879

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 15, 2024
@utam0k utam0k requested a review from a team August 15, 2024 13:05
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 16, 2024

Hey, I think this release should bump the minor number, so 0.4.0 , specially because of #2818 , which is a breaking change. wdyt?

@utam0k
Copy link
Member Author

utam0k commented Aug 17, 2024

Hey, I think this release should bump the minor number, so 0.4.0 , specially because of #2818 , which is a breaking change. wdyt?

Make sense!

@utam0k utam0k changed the title Prepare for v0.3.4 Prepare for v0.4.0 Aug 17, 2024
@utam0k
Copy link
Member Author

utam0k commented Aug 20, 2024

Hey, I think this release should bump the minor number, so 0.4.0 , specially because of #2818 , which is a breaking change. wdyt?

PTAL 🙏

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 20, 2024

Hey the fille changes still show the version diff as 0.3.4 , we need to update that right? Also will the tagpr PR (#2791) for changelog get auto-updated to the 0.4.0 instead of 0.3.4 once we merge this, or we might need to update it manually?

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 20, 2024

ok, so tagpr pr is updated to correct 0.4.0, and it also has the updation of .tagpr that is here, so what changes does this pr exactly needs? Or we can merge the tagpr for the release?

@yihuaf
Copy link
Collaborator

yihuaf commented Aug 20, 2024

I think we can close this in favor of #2791

@utam0k
Copy link
Member Author

utam0k commented Aug 21, 2024

Hey the fille changes still show the version diff as 0.3.4 , we need to update that right? Also will the tagpr PR (#2791) for changelog get auto-updated to the 0.4.0 instead of 0.3.4 once we merge this, or we might need to update it manually?

I forgot git add . 🤦

Signed-off-by: utam0k <[email protected]>
@utam0k
Copy link
Member Author

utam0k commented Aug 21, 2024

ok, so tagpr pr is updated to correct 0.4.0, and it also has the updation of .tagpr that is here, so what changes does this pr exactly needs? Or we can merge the tagpr for the release?

Merging #2791 after merging this PR should complete the release. Sorry for the confusion. The release flow is slightly broken. We hope to have it in place before the next release. Normally, the changes in this PR should be included in #2791, but that is not the case right now.

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 21, 2024

Merging #2791 after merging this PR should complete the release.

ok, got it 👍 I have approved the PR, you can go ahead once the CI is done

@utam0k utam0k merged commit 5e70666 into youki-dev:main Aug 23, 2024
28 checks passed
@utam0k utam0k deleted the prepare-v0.3.4 branch August 23, 2024 12:44
This was referenced Aug 23, 2024
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 23, 2024

@utam0k , I have approved the release env workflows, so v0.4.0 should get released and uploaded to crates.io

@utam0k
Copy link
Member Author

utam0k commented Aug 23, 2024

@utam0k , I have approved the release env workflows, so v0.4.0 should get released and uploaded to crates.io

All of this has already been automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants