docs(main): auto release node using just #2537

cuisongliu · 2023-11-18T04:09:58Z

No description provided.

codecov-commenter · 2023-11-18T04:12:12Z

Codecov Report

Merging #2537 (c8d2228) into main (6bd1281) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   65.86%   65.86%           
=======================================
  Files         133      133           
  Lines       16795    16795           
=======================================
  Hits        11062    11062           
  Misses       5733     5733

utam0k · 2023-11-26T04:35:11Z

.github/workflows/auto_version_up.yaml

+          sudo env PATH=$PATH just version-up ${{ inputs.version }}
+      - uses: peter-evans/create-pull-request@v5
+        with:
+          title: 'docs: Automated docs Update for ${{ inputs.version }}'


Not only docs but also Cargo.toml.

utam0k

Why don't you use tagpr?
https://github.com/Songmu/tagpr

cuisongliu · 2023-11-26T05:35:13Z

Why don't you use tagpr?
https://github.com/Songmu/tagpr

Looks like this would be a good approach.

cuisongliu · 2023-11-26T15:06:46Z

update_version_config.yaml action manually modify version number
merge tagpr-xxx branch
using tagpr action auto commit version change
merge tagpr-from-xxxx branch
auto release new version

utam0k · 2023-11-27T11:10:35Z

.github/workflows/update_version_config.yaml

+      version:
+        description: 'Version to release'
+        required: true
+        default: '0.3.0'


It is not necessary.

Suggested change

default: '0.3.0'

utam0k · 2023-11-27T11:11:38Z

.tagpr

@@ -0,0 +1,7 @@
+[tagpr]


Please add a comment about how we don't need to edit it.

utam0k · 2023-11-27T11:12:02Z

justfile

+    if [[ "{{version}}" == "0.3.0" ]]; then
+        return
+    fi


Why do we need it?

Suggested change

if [[ "{{version}}" == "0.3.0" ]]; then

return

fi

The main thing is that when this PR is submitted, a current version of the PR will be automatically generated. Another way is to change the current default version number to 0.3.1

It's a good time to release 0.3.1. I'd like to release the new version using the new workflow you created! So can we delete it?

Of course, I've deleted it. When the current PR is merged, it will automatically create a new PR. When the new PR is merged, it can be automatically released.

utam0k · 2023-11-27T11:13:03Z

.github/workflows/tagpr.yaml

+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Trigger Release Workflow(only when tagged)
+        uses: actions/github-script@v6
+        if: "steps.tagpr.outputs.tag != '' && steps.tagpr.outputs.tag != 'v0.3.0'"


Please check format instead of v0.3.0.

utam0k · 2023-11-27T11:15:15Z

.github/workflows/update_version_config.yaml

+    inputs:
+      version:
+        description: 'Version to release'
+        required: true
+        default: '0.3.0'


Is it difficult to choose major, minor, or patch to take place of a version?

utam0k · 2023-12-07T13:16:25Z

@cuisongliu Sorry for the late. May I ask you to rebase this PR from the main branch? We extended the timeout for CI.

cuisongliu · 2023-12-07T13:59:01Z

@cuisongliu Sorry for the late. May I ask you to rebase this PR from the main branch? We extended the timeout for CI.

done

utam0k

Looks good except for the conlict

Signed-off-by: cuisongliu <[email protected]>

utam0k · 2023-12-17T11:35:16Z

@cuisongliu Thanks!

cuisongliu mentioned this pull request Nov 18, 2023

docs(main): support arm64 release docs #2510

Merged

cuisongliu force-pushed the auto_release_docs_pr branch from 0160474 to f9be60d Compare November 18, 2023 04:14

utam0k added the kind/documentation label Nov 18, 2023

cuisongliu force-pushed the auto_release_docs_pr branch 6 times, most recently from 8e0c924 to ce3432e Compare November 23, 2023 01:06

cuisongliu marked this pull request as ready for review November 23, 2023 01:06

utam0k reviewed Nov 26, 2023

View reviewed changes

utam0k requested changes Nov 26, 2023

View reviewed changes

cuisongliu force-pushed the auto_release_docs_pr branch 16 times, most recently from 5bc82d5 to 5b2546b Compare November 26, 2023 09:03

cuisongliu force-pushed the auto_release_docs_pr branch 7 times, most recently from be4d74e to 32c610a Compare November 26, 2023 14:59

cuisongliu marked this pull request as ready for review November 26, 2023 15:03

utam0k reviewed Nov 27, 2023

View reviewed changes

.tagpr

@@ -0,0 +1,7 @@

[tagpr]

Copy link

Member

utam0k Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about how we don't need to edit it.

utam0k reviewed Nov 27, 2023

View reviewed changes

cuisongliu force-pushed the auto_release_docs_pr branch 2 times, most recently from d770988 to 073d661 Compare November 27, 2023 17:20

cuisongliu force-pushed the auto_release_docs_pr branch from 4fb2c65 to 7584b59 Compare December 7, 2023 13:51

cuisongliu force-pushed the auto_release_docs_pr branch 2 times, most recently from d53ac07 to fd0a822 Compare December 10, 2023 03:39

utam0k approved these changes Dec 16, 2023

View reviewed changes

docs(main): auto release node using just

c8d2228

Signed-off-by: cuisongliu <[email protected]>

cuisongliu force-pushed the auto_release_docs_pr branch from fd0a822 to c8d2228 Compare December 17, 2023 10:10

utam0k merged commit 9b37c2a into youki-dev:main Dec 17, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 17, 2023

Release for v0.3.1 #2570

Merged

cuisongliu deleted the auto_release_docs_pr branch December 17, 2023 11:39

This was referenced Dec 19, 2023

Release for v0.3.1 #2578

Merged

Release for v0.3.1 #2579

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(main): auto release node using just #2537

docs(main): auto release node using just #2537

cuisongliu commented Nov 18, 2023

codecov-commenter commented Nov 18, 2023 •

edited

Loading

utam0k Nov 26, 2023

utam0k left a comment

cuisongliu commented Nov 26, 2023

cuisongliu commented Nov 26, 2023

utam0k Nov 27, 2023

utam0k Nov 27, 2023

utam0k Nov 27, 2023

cuisongliu Nov 27, 2023

utam0k Dec 8, 2023 •

edited

Loading

cuisongliu Dec 10, 2023

utam0k Nov 27, 2023

utam0k Nov 27, 2023

utam0k commented Dec 7, 2023

cuisongliu commented Dec 7, 2023

utam0k left a comment

utam0k commented Dec 17, 2023

docs(main): auto release node using just #2537

docs(main): auto release node using just #2537

Conversation

cuisongliu commented Nov 18, 2023

codecov-commenter commented Nov 18, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

utam0k left a comment

Choose a reason for hiding this comment

cuisongliu commented Nov 26, 2023

cuisongliu commented Nov 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utam0k Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utam0k commented Dec 7, 2023

cuisongliu commented Dec 7, 2023

utam0k left a comment

Choose a reason for hiding this comment

utam0k commented Dec 17, 2023

codecov-commenter commented Nov 18, 2023 •

edited

Loading

utam0k Dec 8, 2023 •

edited

Loading