Add initial tests for rootless podman #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
- Coverage 65.99% 65.98% -0.01%
==========================================
Files 133 133
Lines 16814 16814
==========================================
- Hits 11096 11095 -1
- Misses 5718 5719 +1 |
YJDoc2
force-pushed
the
test/rootless-tests
branch
from
e1c1451 to
9c74b5e
Compare
|
@utam0k May I ask you to take a quick look at this, so I can continue with the actual test refactor? |
utam0k
approved these changes
Oct 9, 2023
|
Thank you 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple script for validating rootless podman works with youki, now that #2370 is merged. This is not a "proper" test, just a basic bash script which will error if any of the steps error out ; but I'm planning out a small refactoring of rust integration tests, and these tests will be easier to implement in rust once that is done. So I'll be porting the script to proper crate once that is done. This, in the meantime, will make sure we don't accidentally regress the rootless support.