Implement clone3 fallback to clone when ENOSYS returns
#2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
+ Coverage 64.82% 65.00% +0.17%
==========================================
Files 129 129
Lines 14768 14863 +95
==========================================
+ Hits 9573 9661 +88
- Misses 5195 5202 +7 |
yihuaf
force-pushed
the
yihuaf/clone_syscall
branch
from
6dca5a1 to
2db208f
Compare
implements a clone fallback path when `clone3` is blocked with ENOSYS Removed the use of clone3 crate. Our usecase for the clone3 crate is very specific and do not need to support everything. I can easily replace the clone3 crate with a few lines of code, so I did it in this PR. We usually favors safe syscall wrappers like nix over libc, but I believe the save is worth it here. We use the raw clone syscall instead of glibc wrapper. Details are in the comments. Using raw syscalls for both clone and clone3 actually makes the code well organized. For our usecase, they share the input types. Unit tests using seccomp profile to simulate clone3 being blocked are added. Signed-off-by: yihuaf <[email protected]>
yihuaf
force-pushed
the
yihuaf/clone_syscall
branch
from
2db208f to
884d7e8
Compare
|
Holding off on this one. It seems we should not be calling raw syscall directly without glibc for clone or clone3... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2030
Potentially controversial:
clone3crate. Our usecase for the clone3 syscall is very specific and do not need to support everything. I can easily replace the clone3 crate with a few lines of code, so I did it in this PR. We usually favors safe syscall wrappers likenixoverlibc, but I believe the save is worth it here.clonesyscall instead ofglibcwrapper. Details are in the comments.Otherwise, this PR does what the RFC outline. Unit tests using seccomp profile to simulate clone3 being blocked are added.
Also, I implemented fallback for
ENOSYSonly. Technically, we can addEPERMto the list as well.