-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: New Alarm Layout #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only some minor things I noticed when testing:
- The "Sound" switch can't be disabled for some reason, it always stays enabled.
- The "Sound" row has a divider between the sound selection menu and the switch, while the "Vibrate" row doesn't. I propose to add the divider to the "Vibrate" row too.
- The "Label" text field could use the fill width in my opinion - currently there's some free space at the right.
- The area that can be used for changing the time in the number picker is quite small, I'd suggest to add some horizontal padding to it that also reacts to scroll gestures.
This should probably also solve the performance issue when scrolling? :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like many of these changes, like hiding the labels when empty and the reordering of the alarm prefs. I don't really like moving it to a separate sheet though. I think having all information on one screen is an advantage and the less navigation is required the better. I also like leaving the alarms expanded to see when they will ring at a glance, which wouldn't be possible anymore and instead require navigating back and forth. AOSP and G-Clock also work with animated visibility, which is the best choice for this use case imo. Performance issues are mostly a problem with compose and will be improved over time. Also I haven't noticed any myself and my device is a four years old mid ranger, so I doubt they're a major inconvenience. I'd be for taking most of these changes and applying them to the alarm cards. I think that would look really nice.
e0933b1
to
94c20c5
Compare
Moved all the clutter from alarm row into a separate alarm settings sheet
closes #239