Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PollState variants #92

Merged

Conversation

matheus-consoli
Copy link
Collaborator

Closes #88

I also "hid" PollState::Ready behind a set_ready. Now no one outside utils/poll_state/poll_state.rs references the variants by name.

Copy link
Owner

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@yoshuawuyts yoshuawuyts merged commit 330c8ee into yoshuawuyts:main Nov 17, 2022
@matheus-consoli matheus-consoli deleted the pollstate-set-ready-set-consumed branch November 17, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PollState{,s}::set_consumed
2 participants