Added backgroundOpacity option #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKragh
commented
Jan 1, 2024
| @@ -732,6 +740,7 @@ const create3DContrib = (svg, userInfo, x, y, width, height, settings, isForcedA | |||
| const week = Math.floor(diffDate(startTime, cal.date.getTime()) / 7); | |||
| const baseX = offsetX + (week - dayOfWeek) * dx; | |||
| const baseY = offsetY + (week + dayOfWeek) * dy; | |||
| // ref. https://github.com/yoshi389111/github-profile-3d-contrib/issues/27 | |||
There was a problem hiding this comment.
Please don't ask me how this occurred! I suspect my IDE playing a trick on me here! Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you for this awesome project! I'm kind of lazy in terms of pleasing light/dark modes, and usually try to fix with a transparent background, and seemed like I could do that for my own Github Person page.
Anyhow, just wanted to contribute back so here is a PR.
To use add in the following to the JSON.
"backgroundOpacity": 0.0to make totally transparent and"backgroundOpacity": 1.0is solid.I know nothing about TypeScript , just call me Jon Snow! Hope I did it right by your standards and the PR makes sense.