Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button full with props and name prop icons #125

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Conversation

vitran12
Copy link
Contributor

@vitran12 vitran12 commented Jun 19, 2024

What this PR does / why we need it:

  • Update button full with props and name prop icons
    Special notes for your reviewer:

Which issue(s) this PR fixes:

Fixes #

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • Style
    • Updated SVG attribute names across multiple icon components to follow camelCase conventions for better compatibility with JSX.
  • New Features
    • Enhanced button component to support more flexible link types (string or object).

@vitran12 vitran12 self-assigned this Jun 19, 2024
@vitran12 vitran12 merged commit 6a4e973 into main Jun 19, 2024
1 of 2 checks passed
@vitran12 vitran12 deleted the alice/update-icon branch June 19, 2024 08:48
Copy link

coderabbitai bot commented Jun 19, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

This update primarily focuses on standardizing the naming conventions for SVG attributes in various icon components, ensuring consistency in code style by converting from kebab-case to camelCase. Additionally, the Button.tsx component has been enhanced to support more flexible prop types for wLink and hLink. The version in package.json has been incremented from 0.5.15 to 0.5.16 to reflect these changes.

Changes

Files Change Summary
package.json Incremented version number from 0.5.15 to 0.5.16.
src/components/ui/button/Button.tsx Modified wLink and hLink properties in ButtonNormalProps to accept both string and object types.
src/components/ui/icons/close-icon.tsx Updated stroke-linecap and stroke-linejoin to strokeLinecap and strokeLinejoin.
src/components/ui/icons/icon_arrow.tsx, icon_arrow_left.tsx, ... Updated attributes fill-rule and clip-rule to fillRule and clipRule respectively across multiple SVG path elements for consistency.
src/components/ui/icons/icon_copy.tsx Changed stroke-width attribute to strokeWidth in multiple SVG paths.
src/components/ui/icons/icon_slack.tsx Converted enable-background to enableBackground, and updated fill-rule and clip-rule to camelCase equivalents in IconSlack.

A tiny patch that makes a smile,
Tidying up code mile by mile.
From buttons linking near and far,
To icons chasing rules ajar.
Let’s raise our paws for version sixteen,
Where clean code reigns, crisp, and pristine. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant