Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement yorkie.Tree for text editors using tree model #90

Merged
merged 50 commits into from
Aug 17, 2023
Merged

Implement yorkie.Tree for text editors using tree model #90

merged 50 commits into from
Aug 17, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Jul 21, 2023

What this PR does / why we need it:

Implemented up to version 0.4.4 of JS.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #90 (6d84ab0) into main (e02ff33) will decrease coverage by 2.46%.
The diff coverage is 45.27%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   56.05%   53.60%   -2.46%     
==========================================
  Files          92      102      +10     
  Lines       14695    18483    +3788     
==========================================
+ Hits         8238     9907    +1669     
- Misses       6457     8576    +2119     
Files Changed Coverage Δ
Sources/API/V1/yorkie/v1/resources.pb.swift 6.24% <0.00%> (-1.01%) ⬇️
Sources/API/V1/yorkie/v1/yorkie.grpc.swift 0.00% <ø> (ø)
Sources/API/V1/yorkie/v1/yorkie.pb.swift 0.00% <0.00%> (ø)
Sources/Core/Client.swift 0.60% <0.00%> (-0.03%) ⬇️
Sources/Document/CRDT/CRDTElement.swift 92.30% <ø> (ø)
Sources/Document/Json/ObjectDataHandler.swift 0.00% <0.00%> (ø)
Sources/Document/Operation/IncreaseOperation.swift 73.80% <0.00%> (ø)
Sources/Document/Operation/Operation.swift 39.43% <0.00%> (-21.44%) ⬇️
Sources/Document/Operation/SelectOperation.swift 46.34% <0.00%> (ø)
Sources/Document/Operation/StyleOperation.swift 52.50% <0.00%> (ø)
... and 54 more

@humdrum humdrum self-assigned this Jul 26, 2023
@humdrum humdrum added this to the 0.4.4 milestone Jul 26, 2023
Sources/Document/Json/JSONTree.swift Show resolved Hide resolved
Sources/Document/Json/JSONTree.swift Outdated Show resolved Hide resolved
Sources/Document/Json/JSONTree.swift Outdated Show resolved Hide resolved
Sources/Core/Client.swift Show resolved Hide resolved
@humdrum humdrum merged commit 653c066 into main Aug 17, 2023
2 checks passed
@humdrum humdrum deleted the tree branch August 17, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants