Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHTNode removal to converter for consistency #182

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Jun 12, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Introduced isRemoved property to enhance node attribute handling.
    • Added style handling and conversion functionalities for JSONTree nodes.
  • Bug Fixes

    • Improved deepcopy method accuracy in RHT class.
  • Tests

    • Added unit tests for new isRemoved property and JSONTree style functionalities.
    • Implemented tests to verify the correctness of the deepcopy method in RHT class.

@humdrum humdrum self-assigned this Jun 12, 2024
Copy link
Contributor

coderabbitai bot commented Jun 12, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The recent changes introduce a new isRemoved property to several structures and methods across various files, enhancing the functionality to track the removal status of nodes. This includes updates to protobuf definitions, internal methods, and test cases to ensure the new property is correctly handled and tested.

Changes

Files Change Summary
Sources/API/Converter.swift Added isRemoved property to pbNodeAttr struct and updated set method call to setInternal.
Sources/API/V1/Generated/yorkie/v1/resources.pb.swift Added isRemoved variable to Yorkie_V1_NodeAttr struct and updated related functions.
Sources/API/V1/yorkie/v1/resources.proto Added is_removed boolean field to NodeAttr message.
Sources/Document/CRDT/RHT.swift Introduced setInternal method and updated deepcopy method to use it.
Tests/Unit/API/V1/ConverterTests.swift Added tests for styling JSONTree nodes, converting to XML, and removing styles.
Tests/Unit/Document/CRDT/RHTTests.swift Added test_should_deepcopy_correctly() to verify deepcopy() method correctness.

Poem

🐰 In the code where nodes reside,
A new flag now can confide,
isRemoved it proudly stands,
Marking changes with careful hands.
Tests and structs, all aligned,
In the realm of bits, well-defined.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Base automatically changed from tree-style-change to main June 12, 2024 07:42
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (b5b7462) to head (9ebf775).

Files Patch % Lines
...rces/API/V1/Generated/yorkie/v1/resources.pb.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   45.23%   45.47%   +0.24%     
==========================================
  Files         105      105              
  Lines       19158    19180      +22     
==========================================
+ Hits         8666     8722      +56     
+ Misses      10492    10458      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit 01142d8 into main Jun 12, 2024
3 checks passed
@humdrum humdrum deleted the rht-encoding branch June 12, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants