Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrent editing and styling in Tree #166

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 17, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 36.66667% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 40.87%. Comparing base (bacbf9c) to head (6462d14).

Files Patch % Lines
Sources/Document/CRDT/CRDTTree.swift 21.73% 36 Missing ⚠️
Sources/API/V1/yorkie/v1/resources.pb.swift 0.00% 8 Missing ⚠️
Sources/Document/Json/JSONTree.swift 0.00% 5 Missing ⚠️
Sources/API/Converter.swift 0.00% 4 Missing ⚠️
...ources/Document/Operation/TreeSytleOperation.swift 0.00% 3 Missing ⚠️
Sources/Document/CRDT/RGATreeSplit.swift 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   40.95%   40.87%   -0.08%     
==========================================
  Files         105      105              
  Lines       17936    17969      +33     
==========================================
  Hits         7345     7345              
- Misses      10591    10624      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@humdrum humdrum merged commit 4b063d8 into main May 17, 2024
3 checks passed
@humdrum humdrum deleted the concurrent-tree-style branch May 17, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants