Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presence issues. #163

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix presence issues. #163

merged 2 commits into from
May 3, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 2, 2024

What this PR does / why we need it:

  • Fix missing my presence info after updating the document.
  • Refactor Document.update() to same as JS.
  • Add a excludeMyself parameter to the getPresences()

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested a review from myupage May 2, 2024 11:40
@humdrum humdrum self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 8.25688% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 40.95%. Comparing base (d59643b) to head (80d994f).

Files Patch % Lines
Tests/Integration/PresenceTests.swift 0.00% 96 Missing ⚠️
Sources/Document/Document.swift 72.72% 3 Missing ⚠️
Sources/Document/Change/Change.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   41.18%   40.95%   -0.24%     
==========================================
  Files         105      105              
  Lines       17835    17936     +101     
==========================================
  Hits         7345     7345              
- Misses      10490    10591     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit bacbf9c into main May 3, 2024
3 checks passed
@humdrum humdrum deleted the fix-presence branch May 3, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants