Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client constructor support URL address #162

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add Client constructor support URL address #162

merged 1 commit into from
Apr 19, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Apr 19, 2024

What this PR does / why we need it:

  • Added functionality so that commonly used URLs can be used to create a client

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum requested a review from myupage April 19, 2024 06:32
@humdrum humdrum self-assigned this Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 41.17%. Comparing base (0aa1f3e) to head (a43d7c9).

Files Patch % Lines
Sources/Core/Client.swift 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   41.12%   41.17%   +0.04%     
==========================================
  Files         104      105       +1     
  Lines       17810    17833      +23     
==========================================
+ Hits         7325     7343      +18     
- Misses      10485    10490       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit c957485 into main Apr 19, 2024
3 checks passed
@humdrum humdrum deleted the url_address branch April 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants