-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy to clipboard (#74) and markdown formatting (#78) features to makeOxygen()
#79
Conversation
Also replaces superseded `@return` tag with updated `@returns` + replaces `writeLines()` with `cli_code()` Also update DESCRIPTION by removing miniUI + shiny from Imports (also listed in Suggests), adds rlang to Imports, and add "Encoding: UTF-8"
If this is a welcome pull request, it may be helpful to add an option to set the |
thanks for the PR. I will review it shortly |
- rename use_md to markdown for consistency w/ usethis - drop rlang from imports - add helper functions obj_lbl + prep_fn_roxy + prep_tbl_roxy + set_roxy_header
Also swamp message for cli functions
- Fix issue w/ substitute handling of env - Add use_labels parameter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
===========================================
+ Coverage 22.00% 35.53% +13.53%
===========================================
Files 28 28
Lines 1177 1255 +78
===========================================
+ Hits 259 446 +187
+ Misses 918 809 -109 ☔ View full report in Codecov by Sentry. |
Gha shows that {crayon} is missing from desc file. There is still a crayon::red somewhere hanging around that is being picked up in the ns. |
I’ll take a look and also fix the test coverage issues! The scope of this PR expanded a good bit beyond my initial draft back in August when I got back to it last night so, if you want some but not all of the code, just let me know and I can pull those changes back out again. |
Also add make_oxygen alias
Also - avoids copying code from each file to clipboard - adds make_oxy_file alias - invisibly returns file list - cleans up transition to cli
Also add make_dictionary alias
Add tests for makeOxyFile + makeOxygen
Also add dir.out argument (using same arg name as untangle) + expand tests
Also tidy DESCRIPTION
I think I got the code coverage issues fixed. The main additions beyond the original additional of auto-copying with
I use sinew all the time and I'd love to get these changes into the package if possible. Let me know if any additional changes are needed! |
@elipousson it is great to hear that you are using the package! I think the only thing left is to bump the version. Enough changes have been made to move from 0.4 to 0.5. After you change that I'll merge it into master. Thanks for all the contributions! |
@elipousson thanks again for all the contributions and hard work of thinking how to refactor the package. |
@yonicd My pleasure! I have a few additional tweaks in mind but didn't want to crowd an already crowded PR after you had already signed off. Time permitting, I may open a new GitHub issue with those ideas in the next few weeks. |
Also:
writeLines()
when printing output withcli_code()