Remove repeated message chat badge animation that causes huge performance issue for low-end users and replaces it with flashing #22845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynot01
approved these changes
Dec 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
warface1234455
force-pushed
the
chat-moment
branch
from
e2209a2 to
c6ce57e
Compare
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
ynot01
approved these changes
Dec 12, 2024
warface1234455
changed the title
|
This is actually related to looking up/down being expensive, i will fix this when i do a bulk multiz bug fixing update |
|
FIGHT! FIGHT! FIGHT! FIGHT! FIGHT! FIGHT! FIGHT! FIGHT! FIGHT! |
ToasterBiome
requested changes
Dec 12, 2024
Dude thats just an example for the repeated messages |
This has nothing to do with this, it's about the animation flickers when you type something twice |
wish granted |
ToasterBiome
approved these changes
Dec 13, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTMERGE REQUEST
gotta make sure it works for other users in game
Document the changes in your pull request
Remove repeated message chat badge animation that causes huge performance issue for low-end users and replaces it with flashing
Why is this good for the game?
this animation happens once is fine but with 1000 actions at the same time causes the entire chat screen to flicker and cause lag, potentially crashing a client
Testing
Changelog
🆑
experimental: Remove repeated message chat badge animation that causes huge performance issue for low-end users and replaces it with flashing
/:cl: