-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a few mentor bugs #22825
Merged
ToasterBiome
merged 7 commits into
yogstation13:master
from
Oblisk234:fixesmentorproblems
Dec 30, 2024
Merged
Fixes a few mentor bugs #22825
ToasterBiome
merged 7 commits into
yogstation13:master
from
Oblisk234:fixesmentorproblems
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added a commit
that referenced
this pull request
Dec 5, 2024
Oblisk234
added
Test Merge - Scheduled
This PR is waiting to be test merged
TESTMERGED
This PR is currently live in a test merge.
labels
Dec 5, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 6, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 8, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 11, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 12, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 13, 2024
This was referenced Dec 19, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 22, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 25, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 29, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 29, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 30, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 30, 2024
ToasterBiome
approved these changes
Dec 30, 2024
Yogbot-13
added a commit
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Admin
This PR affects administrators
Fix
This fixes an issue. Please link issues in fix PRs
Test Merge - Scheduled
This PR is waiting to be test merged
TESTMERGED
This PR is currently live in a test merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22794
Document the changes in your pull request
Fixes mentorwho overreminding people that "Mentorhelps are also sent to Discord. If no mentors are available in game mentorhelp anyways and a mentor on Discord may see it and respond." multiplied per mentor that's on.
Fixes messaging discord mentors not showing the message being sent to them.
Fixes mentor-maintainers/issue hunters' OOC tag becoming [] after readminning, deadminning, and rementoring.
Fixes discord mentor messages not being recorded in mhelp database and mentor tickets.
Testing
Mentorwho:
Sending messages to discord mentors:
OOC tag:
Mentor tickets:
Changelog
🆑
bugfix: Mentorwho will no longer remind you that mentorhelps are also sent to discord multiplied by the amount of mentors that are on the server.
bugfix: You can now see your messages to mentors on discord again.
bugfix: Mentor-maintainers/issue hunters' OOC tag will no longer evaporate into [] after readminning, deadminning, and rementoring.
bugfix: Discord mentor messages are now recorded in mhelp database and mentor tickets.
/:cl: