Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few mentor bugs #22825

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Conversation

Oblisk234
Copy link
Member

@Oblisk234 Oblisk234 commented Nov 30, 2024

Fixes #22794

Document the changes in your pull request

Fixes mentorwho overreminding people that "Mentorhelps are also sent to Discord. If no mentors are available in game mentorhelp anyways and a mentor on Discord may see it and respond." multiplied per mentor that's on.

Fixes messaging discord mentors not showing the message being sent to them.

Fixes mentor-maintainers/issue hunters' OOC tag becoming [] after readminning, deadminning, and rementoring.

Fixes discord mentor messages not being recorded in mhelp database and mentor tickets.

Testing

Mentorwho:
image

Sending messages to discord mentors:
image

OOC tag:
image

Mentor tickets:
image

Changelog

🆑
bugfix: Mentorwho will no longer remind you that mentorhelps are also sent to discord multiplied by the amount of mentors that are on the server.
bugfix: You can now see your messages to mentors on discord again.
bugfix: Mentor-maintainers/issue hunters' OOC tag will no longer evaporate into [] after readminning, deadminning, and rementoring.
bugfix: Discord mentor messages are now recorded in mhelp database and mentor tickets.
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Nov 30, 2024
@Oblisk234 Oblisk234 changed the title Fixes two mentor bugs Fixes a few mentor bugs Dec 1, 2024
@github-actions github-actions bot added the Admin This PR affects administrators label Dec 1, 2024
Yogbot-13 added a commit that referenced this pull request Dec 5, 2024
@Oblisk234 Oblisk234 added Test Merge - Scheduled This PR is waiting to be test merged TESTMERGED This PR is currently live in a test merge. labels Dec 5, 2024
Yogbot-13 added a commit that referenced this pull request Dec 6, 2024
Yogbot-13 added a commit that referenced this pull request Dec 8, 2024
Yogbot-13 added a commit that referenced this pull request Dec 11, 2024
Yogbot-13 added a commit that referenced this pull request Dec 12, 2024
Yogbot-13 added a commit that referenced this pull request Dec 12, 2024
Yogbot-13 added a commit that referenced this pull request Dec 13, 2024
Yogbot-13 added a commit that referenced this pull request Dec 22, 2024
Yogbot-13 added a commit that referenced this pull request Dec 25, 2024
Yogbot-13 added a commit that referenced this pull request Dec 29, 2024
Yogbot-13 added a commit that referenced this pull request Dec 29, 2024
Yogbot-13 added a commit that referenced this pull request Dec 30, 2024
Yogbot-13 added a commit that referenced this pull request Dec 30, 2024
@ToasterBiome ToasterBiome merged commit 6660419 into yogstation13:master Dec 30, 2024
15 checks passed
Yogbot-13 added a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Fix This fixes an issue. Please link issues in fix PRs Test Merge - Scheduled This PR is waiting to be test merged TESTMERGED This PR is currently live in a test merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readminning, deadminning, and then rementoring breaks OOC tags
3 participants