Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds object sprites to CTF armor #22815

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Scrambledeggs00
Copy link
Contributor

@Scrambledeggs00 Scrambledeggs00 commented Nov 19, 2024

Document the changes in your pull request

This just adds the CTF armors' south sprites as their object sprites. Before this, they had no sprites as stated in issue #22801.

Why is this good for the game?

Fixes #22801

Testing

All of the object sprites show correctly and the mob sprites stay as they should be.
Screenshot (278)
Screenshot (279)
Screenshot (280)

Spriting

As said in the description, the sprites are just the armor's south facing sprites, though I moved the suits' boots to be inline with other suit object sprites. You can see them in the testing section.

Changelog

🆑
bugfix: Solved issue #22801
imageadd: Added object sprites to CTF armors
/:cl:

@Scrambledeggs00 Scrambledeggs00 requested a review from a team as a code owner November 19, 2024 19:47
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes labels Nov 19, 2024
@Oblisk234
Copy link
Member

May want to include specifically "Fixes #22801" so it'll be autoclosed.

@Scrambledeggs00
Copy link
Contributor Author

May want to include specifically "Fixes #22801" so it'll be autoclosed.

Anywhere specific I would include it? Can I just put it anywhere in the PR description?

@Oblisk234
Copy link
Member

May want to include specifically "Fixes #22801" so it'll be autoclosed.

Anywhere specific I would include it? Can I just put it anywhere in the PR description?

Anywhere works I think, although I usually just put it at the top.

@Scrambledeggs00
Copy link
Contributor Author

May want to include specifically "Fixes #22801" so it'll be autoclosed.

Anywhere specific I would include it? Can I just put it anywhere in the PR description?

Anywhere works I think, although I usually just put it at the top.

Thanks :]

@ToasterBiome ToasterBiome merged commit bf91e5c into yogstation13:master Nov 21, 2024
15 checks passed
Yogbot-13 added a commit that referenced this pull request Nov 21, 2024
@Scrambledeggs00 Scrambledeggs00 deleted the ctf-icon-sprite-fix branch November 21, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTF hardsuits have no item sprite
5 participants