Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALL MAPS] Adds an inspector booth to the HoP's office beside the desk #22768

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

AMyriad
Copy link
Contributor

@AMyriad AMyriad commented Oct 23, 2024

Document the changes in your pull request

DRAFTED until #22778 is merged

Fulfills this mapping request and sort of avenges #21567, this does as the title says pretty much

The one tradeoff is some things had to be shuffled around in every office, but no functionality should be lost
Also fixes a few mapping errors (varedited windoor icon_state, plating under desk, firedoors under windows, bad wiring, etc.)

Why is this good for the game?

Booth cool, nuff said

Also here are the layout changes so you can see for yourself

BoxStation

Before:
image

After:
image

IceMeta

Before:
image

After:
image

DonutStation

Before:
image

After:
image

NVS Gax

Before:
image

After:
image

ManateeStation

Before:
image

After:
image

MiniStation

Before:
image

After:
image

Testing

Get back to me on that one

Changelog

🆑
mapping: The HoP's office now has an inspector booth beside the desk on all maps
tweak: Some things in the HoP's office have been shuffled around to make room for new inspector booths
bugfix: Fixed chemistry not being able to receive mail on Box
bugfix: Fixed the HoP's disposal chute on Donut not working properly
bugfix: Fixed HoP's desk having a duplicate ID console on Mini
/:cl:

@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Tweak This PR contains changes to the game. labels Oct 23, 2024
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Oct 23, 2024
@wonderinghost
Copy link
Contributor

I keep forgetting about seeding ideas in dm files

@AMyriad AMyriad closed this Nov 10, 2024
@AMyriad AMyriad reopened this Nov 10, 2024
@AMyriad AMyriad marked this pull request as ready for review November 10, 2024 19:36
@AMyriad AMyriad requested a review from a team as a code owner November 10, 2024 19:36
@AMyriad
Copy link
Contributor Author

AMyriad commented Nov 10, 2024

guh wrong button

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@ToasterBiome ToasterBiome merged commit 9465884 into yogstation13:master Nov 21, 2024
18 of 28 checks passed
Yogbot-13 added a commit that referenced this pull request Nov 21, 2024
@AMyriad AMyriad deleted the hop-arstotzka branch November 22, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants