Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the storage implant's button sprite #21203

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

AMyriad
Copy link
Contributor

@AMyriad AMyriad commented Jan 2, 2024

Document the changes in your pull request

This replaces the crusty ass storage implant's button sprite with a newer, more evil looking one.

Why is this good for the game?

Sprite is no longer old and crusty.

Testing

image
Works as intended (sprite updated since this ^)

Spriting

Based on the mining satchel, and I'm happy to make changes if requested
Updated sprite:
image

The current sprite for comparison

image

Wiki Documentation

The current sprite isn't documented anywhere so this one shouldn't need it either.

Changelog

🆑
imageadd: Updated the storage implant's toggle sprite
/:cl:

@AMyriad AMyriad requested a review from a team as a code owner January 2, 2024 14:24
@Yogbot-13 Yogbot-13 added the Sprites This PR has spriting changes label Jan 2, 2024
@AdamPrime314

This comment was marked as abuse.

@ynot01
Copy link
Contributor

ynot01 commented Jan 2, 2024

The shade of red used on the upper half is hard on the eyes

@ThePissGuy
Copy link

thats on purpose the syndicate are EVIL do you expect them to go easy on peoples eyes with colour palette

Copy link
Contributor

@cuackles cuackles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
need that in the red part the difference between the light and dark red becomes more notable, apart from that i like the idea and the design

@AMyriad
Copy link
Contributor Author

AMyriad commented Jan 2, 2024

image need that in the red part the difference between the light and dark red becomes more notable, apart from that i like the idea and the design

Forgot the highlights, now updated with this on the latest commit:
image

@cuackles
Copy link
Contributor

cuackles commented Jan 4, 2024

image need that in the red part the difference between the light and dark red becomes more notable, apart from that i like the idea and the design

Forgot the highlights, now updated with this on the latest commit:
image

Very good, will re review when off work

Copy link
Contributor

@MajManatee MajManatee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeos

@MajManatee MajManatee merged commit f6a8008 into yogstation13:master Jan 5, 2024
12 checks passed
Yogbot-13 added a commit that referenced this pull request Jan 5, 2024
@AMyriad AMyriad deleted the storageicon branch January 5, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants