Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alcoholism wins again (Slurring nerf) #21201

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Alcoholism wins again (Slurring nerf) #21201

merged 4 commits into from
Jan 4, 2024

Conversation

Therandomhoboo
Copy link
Contributor

@Therandomhoboo Therandomhoboo commented Jan 2, 2024

Document the changes in your pull request

Every non-american can understand that you don't slur on 2-3 beers. I don't know who made it that drinking anything with 11% boozepwr would make you slur but clearly they haven't drank. I've fiddled with the numbers to make it more realistic for lightweight drinkers, normal drinkers & alcoholics(drinkers with alcohol tolerance) for slurring.

Drunk value:

11 - Light drinkers will slur for 10 seconds
51- Normal drinkers will slur for 7 seconds
81- Alcohol Tolerant drinkers will slur for 4 seconds

I also removed the constant chance for you to slur as it was pointless considering if you were over 11 in drunk value you were already constantly slurring. Which meant that you would slur on any drink which is fucking dumb.

[Edit}
After thinking over it, I've also reduced the slurring duration based on tiers as well since better drinkers will be able to pull themselves together.

Why is this good for the game?

Because I am a Brit who was an alcoholic at 12 and I didn't slur nearly as much after having 1 drink like these weak-stomached spacemen.

Testing

I can't test because I dont know how to compile to 515 and its my day off

Wiki Documentation

The drunk chart for alcohol drinks need to be edited to reflect the slur for each tier of drinker.

Changelog

🆑

rscadd: Slurring now happens based on what kind of drinker you are (Light, normal or heavy drinker which are based on traits)
rscadd: Slurring duration changed based on drinker type
rscdel: The constant chance to randomly slur, we can drink now

/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this labels Jan 2, 2024
@Yarinoi
Copy link
Contributor

Yarinoi commented Jan 2, 2024

what about the alcohol tolerance gene
edit: nevermind, it looks like the alcohol tolerance gene and the alcohol tolerance quirk both just give you the TRAIT_ALCOHOL_TOLERANCE trait, i.e. do the same thing

@Therandomhoboo
Copy link
Contributor Author

what about the alcohol tolerance gene edit: nevermind, it looks like the alcohol tolerance gene and the alcohol tolerance quirk both just give you the TRAIT_ALCOHOL_TOLERANCE trait, i.e. do the same thing

Yeah I need to fix it up cause i couldnt check it but yee the gene and quirk are the same.

@AdamPrime314

This comment was marked as abuse.

@Therandomhoboo
Copy link
Contributor Author

A nearly useless quirk and gene (Apart from powergaming with Manly Dorf) made to be at least slightly more logical in terms of the only significant effects the bar has on a character.

There are other drinks you can use as well, drinking isn't pointless it is very slept on. People just dont know how to combine drinks. Manly dorf is good but only if you keep hiding otherwise you'll get gunned down easily.

@AdamPrime314

This comment was marked as abuse.

@ToasterBiome ToasterBiome merged commit 45e6b83 into yogstation13:master Jan 4, 2024
12 checks passed
Yogbot-13 added a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants