Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being on fire no longer causes a negative mood effect if you're immune to fire #21162

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

SapphicOverload
Copy link
Contributor

Document the changes in your pull request

Being on fire no longer gives a negative moodlet for being on fire if you're immune to fire, and also fixed an issue with it not clearing itself when it should.

Why is this good for the game?

This is already the case for suits that provide full fire protection, so I see this as just an oversight.

Testing

image
image

Changelog

🆑
tweak: being on fire no longer gives a negative moodlet if you're immune to fire
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Dec 22, 2023
@ThePissGuy
Copy link

it should be a neutral moodlet noting it seems a bit warm in here

@ThePissGuy
Copy link

or "golly gee willickers it sure is a good thing i am protected against this fire engulfing me"

@ToasterBiome ToasterBiome merged commit 3055afb into yogstation13:master Dec 24, 2023
12 checks passed
Yogbot-13 added a commit that referenced this pull request Dec 24, 2023
@SapphicOverload SapphicOverload deleted the fire-mood-effect branch December 24, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants