Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes shadowling + Reworks darkspawn #20581

Merged
merged 812 commits into from
Apr 8, 2024

Conversation

Moltijoe
Copy link
Contributor

@Moltijoe Moltijoe commented Oct 9, 2023

I'm sorta making this PR to keep myself on-track, it's gonna be drafted for a LONG time

based on this
https://forums.yogstation.net/threads/shadowling-darkspawn-rework-feedback.25356/

https://docs.google.com/spreadsheets/d/e/2PACX-1vRU_pRKRM7TOiPzkkW6_vtN6ZULNge_GgmxQxiTKnsCvvAuHKmsuhwXk3cKwZwtGQrwX2yxRMnc7ykd/pubhtml

Document the changes in your pull request

  • Remove shadowlings
  • port light eater component and elements
  • bring back darkspawn and shadowling abilities using actually good code
  • create new abilities to flesh out each class
  • rework gamemode progression
  • Implement the new darkspawn class and shop system
  • Code the tgui menu for the new darkspawn "shop" system
  • add everything to the shop
  • give proper lore-accurate flavour
  • sprites
  • tweak numbers for approximate balance

Why is this good for the game?

Having two mediocre darkness antags instead of one genuinely good one is kinda rough
especially when they can roll back to back
The modularity should make it easier to maintain in the future
Lets people pick what sort of playstyle they want when they roll the antag

Testing

Ongoing

Wiki Documentation

Delete shadowlings entirely, weeks days updating the darkspawn one

Additional thanks:
RG4, Cuackles, Sol, Slicerv, Skrem, Cowbot

🆑 Flikr, Mqiib, Cryphia, Chubbygummibear, Moltijoe
rscadd: Adds new darkspawns (very different)
rscdel: Removes shadowlings from the codebase
rscdel: Deletes old darkspawns
imageadd: add icons for new darkspawns
wip: Darkspawn balance is ongoing, please leave feedback in the discord
/:cl:

@Moltijoe Moltijoe requested review from alexkar598 and a team as code owners October 9, 2023 06:37
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game. labels Oct 9, 2023
@Moltijoe Moltijoe marked this pull request as draft October 9, 2023 06:38
@github-actions github-actions bot added Admin This PR affects administrators Config Config files need to be changed on the host for this to work labels Oct 9, 2023
@LassiH
Copy link

LassiH commented Oct 9, 2023

slings are already are non functional

@Therandomhoboo
Copy link
Contributor

Sad to see one antag go, but in honesty there were like 3 antags that were based on hiding from the dark. I like the 3 classes for this and its getting a rework so all happy days.

@cowbot92
Copy link
Contributor

cowbot92 commented Oct 9, 2023

Could be cool! The main issue with shadowling (they work fine) is that there's an issue with their veil not turning of light sources inside people's pockets & attachments, essentially making them unable to turn off lights. As long as they have a light eater or something that can physically destroy it you're all good.

@github-actions github-actions bot added the tgui This PR affects TGUI label Oct 10, 2023
@alexkar598 alexkar598 removed their request for review October 10, 2023 13:07
@Moltijoe
Copy link
Contributor Author

Moltijoe commented Oct 10, 2023

Could be cool! The main issue with shadowling (they work fine) is that there's an issue with their veil not turning of light sources inside people's pockets & attachments, essentially making them unable to turn off lights. As long as they have a light eater or something that can physically destroy it you're all good.

no longer an issue, ported light eater component and element from tg, now the light eater actually eats all lights
and all 3 classes will get a weapon that can eat lights

@Moltijoe Moltijoe force-pushed the ShadowspawnDarkling branch 2 times, most recently from 5057f42 to 59e385a Compare October 15, 2023 01:57
@MajManatee MajManatee added Awaiting - Action - Author This PR is awaiting an action from the author Awaiting - Action - HD Awaiting action from Jamie labels Oct 17, 2023
@Moltijoe Moltijoe removed the Awaiting - Action - Author This PR is awaiting an action from the author label Oct 18, 2023
@MajManatee MajManatee added the Literally the best PR My god its beautiful label Oct 27, 2023
@github-actions github-actions bot added the Mapping Will result in a change to a map. label Oct 28, 2023
@Moltijoe Moltijoe force-pushed the ShadowspawnDarkling branch from 4190b3e to 9ecb898 Compare October 31, 2023 19:07
@Moltijoe Moltijoe removed Literally the best PR My god its beautiful Awaiting - Action - HD Awaiting action from Jamie labels Nov 4, 2023
@Moltijoe Moltijoe added the Sprites This PR has spriting changes label Feb 25, 2024
@Moltijoe Moltijoe removed the DO NOT MERGE Should not be merged without express approval from a Head Dev label Apr 7, 2024
Yogbot-13 added a commit that referenced this pull request Apr 7, 2024
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im tired boss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin This PR affects administrators Config Config files need to be changed on the host for this to work DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this Sprites This PR has spriting changes Test Merge - Requested This PR is waiting for a test merge to be scheduled Test Merge - Scheduled This PR is waiting to be test merged tgui This PR affects TGUI Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants