Skip to content

Commit

Permalink
Replaces exploit with gamebreaking exploit in PR request template (#2…
Browse files Browse the repository at this point in the history
…0707)

* Replaces exploit with gamebreaking exploit in PR request template

* Update PULL_REQUEST_TEMPLATE.md

* Update CONTRIBUTING.md
  • Loading branch information
JohnFulpWillard authored Oct 24, 2023
1 parent 6acda39 commit 86c2159
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ There is no strict process when it comes to merging pull requests. Pull requests

* We ask that you use the changelog system to document your player facing changes, which prevents our players from being caught unaware by said changes - you can find more information about this [on this wiki page](http://tgstation13.org/wiki/Guide_to_Changelogs).

* If you are fixing a game-breaking bug, it's advised to use the [s] tag to not bring unwanted attention to your pull request. Very rarely is it acceptable to use this label outside of these situations, due to it hiding information from many sources.

* If you are proposing multiple changes, which change many different aspects of the code, you are expected to section them off into different pull requests in order to make it easier to review them and to deny/accept the changes that are deemed acceptable.

* If your pull request is accepted, the code you add no longer belongs exclusively to you but to everyone; everyone is free to work on it, but you are also free to support or object to any changes being made, which will likely hold more weight, as you're the one who added the feature. It is a shame this has to be explicitly said, but there have been cases where this would've saved some trouble.
Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Mention if you have tested your changes. If you changed a map, make sure you use
If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420.
Prefix the PR title with [admin] if it involves something admin related.
Prefix the PR title with [s] if you are fixing an exploit, so that it is not announced on the Yogstation Discord and the server.
Prefix the PR title with [s] if you are fixing a game-breaking exploit, so that it is not announced on the Yogstation Discord and the server.
Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying.-->

Expand Down

0 comments on commit 86c2159

Please sign in to comment.