Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert user input to lowercase #1131

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Convert user input to lowercase #1131

merged 3 commits into from
Dec 18, 2023

Conversation

jxdv
Copy link
Contributor

@jxdv jxdv commented Dec 12, 2023 •
edited
Loading

Convert user input in update.sh & install.sh to lowercase, so the script(s) won't complain about Y / N.

AnonymousWP
AnonymousWP previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be applied to different parts in the uninstall.sh and update.sh as well.

@jxdv
Copy link
Contributor Author

jxdv commented Dec 13, 2023

Maybe this can be applied to different parts in the uninstall.sh and update.sh as well.

I presume you meant uninstall.sh and install.sh since I've already updated update.sh, and yes looks like It is applicable there also. I'll update those scripts.

@jxdv jxdv changed the title Convert answer to lowercase Convert user input to lowercase Dec 13, 2023
@jxdv
Copy link
Contributor Author

jxdv commented Dec 13, 2023

Converted the user input to lowercase in install.sh. IMO uninstall.sh doesn't need a change.

@yogeshojha yogeshojha added this to the release 2.1.0 milestone Dec 18, 2023
@yogeshojha yogeshojha changed the base branch from master to release/2.1.0 December 18, 2023 01:36
@yogeshojha
Copy link
Owner

@jxdv please resolve the conflict

@jxdv
Copy link
Contributor Author

jxdv commented Dec 18, 2023

@jxdv please resolve the conflict

Done.

@AnonymousWP AnonymousWP merged commit 478f9d3 into yogeshojha:release/2.1.0 Dec 18, 2023
1 check passed
@jxdv jxdv deleted the update-script branch December 18, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyray psyray psyray approved these changes

@AnonymousWP AnonymousWP AnonymousWP approved these changes

@yogeshojha yogeshojha Awaiting requested review from yogeshojha

Assignees
No one assigned
Labels
release/2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jxdv @yogeshojha @psyray @AnonymousWP