Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Handle common directories variables #98

Conversation

idillon-sfl
Copy link
Member

@idillon-sfl idillon-sfl commented Feb 10, 2024

This handles the variables defined in https://git.yoctoproject.org/poky/plain/meta/conf/bitbake.conf

  • They do not appear anymore as undefined when shellcheck is installed
  • They are suggested as completion items in variable expansions or python datastore variables, but not in other places, such as variable assignment
    Screenshot from 2024-02-09 20-28-40

Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a new array of variable names, I think you should rather make available Ziwei's scanned variables for:

  • hover value
  • completion
    And the bitbake variables document hovers.

client/src/language/diagnosticsSupport.ts Show resolved Hide resolved
client/src/lib/src/availableVariables.ts Show resolved Hide resolved
server/src/__tests__/completions.test.ts Show resolved Hide resolved
@idillon-sfl idillon-sfl merged commit 95f7e57 into yoctoproject:staging Feb 13, 2024
2 checks passed
@idillon-sfl idillon-sfl deleted the Feature-10411-add-common-directories-to-variable-expansion-suggestions branch February 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants