Go to definition for symbols in declaration and variable expansion syntax in the current file and included files #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioioioio
approved these changes
Nov 30, 2023
idillon-sfl
previously approved these changes
Nov 30, 2023
…nformation with all the references of each unique symbol Since a symbol can appear multiple times in a file in a declaration-like statement, we store all of them and use them to provide go to definition feature. However, in the context of code completion, one symbol will appear only once.
…expansion syntax now show the references in the current file too
…e for both declaration and variable expansion syntax
…ove duplicate test
WilsonZiweiWang
force-pushed
the
Refactor-SymbolScanner
branch
from
42277dd to
46743bb
Compare
deribaucourt
reviewed
Dec 1, 2023
WilsonZiweiWang
force-pushed
the
Refactor-SymbolScanner
branch
from
46743bb to
413a2f8
Compare
deribaucourt
approved these changes
Dec 1, 2023
Freed-Wu
pushed a commit
to Freed-Wu/coc-bitbake
that referenced
this pull request
Mar 3, 2024
…ents Fix: Fix documents' handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the GlobalDeclaration objects in order to provide the
go to definitionfor symbols with multi-sources. Also worked on extra refactoring since some features depend on this object.Now the
go to definitionis working on variables in either declaration and variable expansion syntax.sample results:
Declaration
Variable expansion
Caveat:Fixed by 42277ddThego to definitionwon't show the sources in the included files before the scan completes. However, when the scan completes, the process to extract the definition location has finished. Additional input in the document is required to trigger theanalyze()again to re-extract the definition locations.~~Possible Solution: ~~
Trigger anotheranalyze()when the scan completes.