Fix container scanner paths when a different mountpoint is used #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
force-pushed
the
relative-scanner
branch
4 times, most recently
from
86fa0d5 to
796eeda
Compare
If a docker container commandWrapper is used, the workdir may be different from the host system. This patch resolves the path to the host system by finding the inode of the host workdir in the container.
In the case of a docker container commandWrapper, the env script may exist in a different location than the one on the host. So don't check for the env script if a command wrapper is set.
When going through a commandWrapper, some logs may be injected. This is the case with poky/crops. This patch fixes the parsing of the inode number by using a regex.
This patch adds a new setting `bitbake.shellEnv` which allows to set environment variables before running the BitBake command. This allows customizing oe-init-build-env but also kas, cqfd and other build tools.
This test verifies callink bitbake from a docker container with a complex mount point.
If the mount point was a parent directory of the bitbake.workingDir, and the layers were symlinks to directories outside of the workingDir, the layer resolution would fail. We now itterate on the host parent directories inodes also.
This greatly speeds up the scanner when we are looking for corresponding container mount points. The scanner now runs only one find command instead of one per directory level in the layer path.
deribaucourt
force-pushed
the
relative-scanner
branch
from
796eeda to
2c25cc3
Compare
deribaucourt
requested review from
idillon-sfl and
WilsonZiweiWang
and removed request for
idillon-sfl
WilsonZiweiWang
approved these changes
Dec 7, 2023
Freed-Wu
pushed a commit
to Freed-Wu/coc-bitbake
that referenced
this pull request
Mar 3, 2024
Feat: Add definition on hover for variables defined by BitBake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.