Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Handle hover on second parameter for Python functions accessing the datastore #48

Merged

Conversation

idillon-sfl
Copy link
Member

This ensure the description of the second parameter will be showed on the second parameter of d.renameVar("test", "DESCRIPTION"). It also ensure it will not be showed on the second parameter of d.getVar("DESCRIPTION", "DESCRIPTION"), as it is currently the case on the staging branch.

Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments make the code very easy to read, great!
An idea: Why not also test function names for first parameter functions as well? (getVar, setVar)

@idillon-sfl
Copy link
Member Author

I believe it is already tested in the shows definition on hovering variable in Python functions for accessing datastore section of the tests. For example, shouldNotShow3 tests that d.test('DESCRIPTION') won't show any hover on "DESCRIPTION". Is it what you mean?

However, I have in mind maybe there should be an other way to organize tests that would make it easier to identify want they test.

@deribaucourt
Copy link
Member

OK that's perfect

@idillon-sfl idillon-sfl merged commit 323260e into yoctoproject:staging Jan 5, 2024
1 check passed
@idillon-sfl idillon-sfl deleted the handle-renameVar branch January 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants