-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Yoav Ram
committed
Mar 7, 2013
1 parent
f5778d5
commit 5ed4dbf
Showing
1 changed file
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ed4dbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? This breaks
\\(...\\)
math in preview.Only when running locally — the heroku versions seems to be prior to this commit.
(working on a PR fixing this and some of #43, #46)
5ed4dbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I had written a more detailed comment on that commit.
If I recall correctly, the
\\(...\\)
syntax caused some problems in the live HTML preview.Can you have a look in the version in PR #47 and see that HTML preview is working nice with the
\\(...\\)
?5ed4dbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's why I undid this in the PR — tested (locally) that it's rendering it into math instead of leaving it as
\(...\)
.Of course, I could be missing some more subtle problems... I'll try to test on a big document with lots of various math.
5ed4dbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, great, keep me updated.