Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load GPU cache without AYON containerized object set #223

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 20, 2025

Changelog Description

Load GPU cache with the AYON metadata imprinted directly onto the GPU cache shape node. This allows duplicating, deleting and instancing the GPU cache nodes as an artist usually whilst AYON would continue to be able to track it.

Additional review information

Because the gpuCache node already has an attribute called representation this meant that for this 'imprinting' to be allowed that the attributes were required to be prefixed with AYON_ to avoid clashes. Which means that listing loaded containers now requires looking for both the AYON_id and id attributes.

Testing notes:

  1. Loading GPU caches should work
  2. Managing GPU caches should work (incl. legacy GPU caches)
  3. Check whether publishing e.g. layouts still work as intended, as they might be expecting an additional 'root' group node
  4. Check whether publishing works with input links being detected correctly

@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Jan 20, 2025
@BigRoy BigRoy self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant