Yume Nikki - Fix the Hebrew translation (for now) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the display of the Hebrew translation, by adding a font, and rewriting how the text is displayed. Change the name of the language on the menu to Hebrew due to not being able to be displayed until being selected if the language was written in its original language, and remove useless files. Adjust the spacing of some lines to be centered. While this will work for some time, due to a lack of Bidi-algorithm in the EasyRPG Player at the moment (EasyRPG/Player#2982), every description in the RPG_RT.ldb.po file (+ save, load, quit lines) will have to be edited another time due to the . character altering how the text is written + how descriptions are handled, so I had to edit lines to take into account this. Fix to do for the future once said algorithm is supported: take the RPG_RT.ldb.po version of this translation prior to this pull request, take all of the lines of text, and revert the text without having to deal with manually adjusting the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the display of the Hebrew translation, by adding a font, and rewriting how the text is displayed. Change the name of the language on the menu to Hebrew due to not being able to be displayed until being selected if the language was written in its original language, and remove useless files. Adjust the spacing of some lines to be centered.
While this will work for some time, due to a lack of Bidi-algorithm in the EasyRPG Player at the moment (EasyRPG/Player#2982), every description in the RPG_RT.ldb.po file (+ save, load, quit lines) will have to be edited another time due to the . character altering how the text is written + how descriptions are handled, so I had to edit lines to take into account this. Fix to do for the future once said algorithm is supported: take the RPG_RT.ldb.po version of this translation prior to this pull request, take all of the lines of text, and revert the text without having to deal with manually adjusting the text.