Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old/unused files from previous generated versions #79

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

bradymholt
Copy link
Member

@bradymholt bradymholt commented Jul 8, 2024

Fixes #76 by removing old generated files that are no longer in use. As the spec has changed and things have been renamed, old files have not been cleaned up. This fixes that.

Also:

  • A change to prevent this from happening in the future
  • (Misc) Remove remaining references to "Swagger"

@bradymholt bradymholt changed the title Rm old docs Remove old/unused files from previous generated version Jul 8, 2024
@bradymholt bradymholt changed the title Remove old/unused files from previous generated version Remove old/unused files from previous generated versions Jul 8, 2024
sh "wget https://api.ynab.com/papi/#{spec_filename} -O ./#{spec_filename}"
# Remove existing generated files to ensure old files are not included in the gem
sh "rm -r docs/ lib/ynab/models/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should prevent this from happening in future.

@bradymholt bradymholt requested review from a team and jorgehmv and removed request for a team July 8, 2024 22:19
@bradymholt
Copy link
Member Author

@jorgehmv Please let me know if you need additional context here.

Copy link
Member

@jorgehmv jorgehmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! sorry for the delay

@bradymholt bradymholt merged commit eb47e1b into main Jul 10, 2024
1 check passed
@bradymholt bradymholt deleted the rm-old-docs branch July 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the SaveTransaction class unused?
2 participants