Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for multiple fakes to occur #67

Merged
merged 5 commits into from
May 28, 2024
Merged

Allows for multiple fakes to occur #67

merged 5 commits into from
May 28, 2024

Conversation

peterfox
Copy link
Collaborator

Changes In Code

  • FeatureFake now implements the Fake interface
  • FeatureFake manager property is now public
  • The Facade now checks if the Features interface is already faked in the container and reuses the manager when faking additional times.

Issue ticket number / Business Case

Slightly improved implementation of #66

Checklist before requesting a review

  • I have written PHPUnit tests.
  • I have updated the documentation and opened a pull request within
    the feature flags documentation repo.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.
  • I have added the enhancement label for a new feature.

@peterfox peterfox added the bug Something isn't working label May 25, 2024
@peterfox peterfox self-assigned this May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (6223858) to head (91b2493).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #67      +/-   ##
============================================
+ Coverage     82.84%   82.94%   +0.09%     
- Complexity      202      203       +1     
============================================
  Files            31       31              
  Lines           548      551       +3     
============================================
+ Hits            454      457       +3     
  Misses           94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfox peterfox merged commit 371350e into main May 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant