Skip to content

remove custom added "<?php\n" for php 8.3 #20344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mixxael
Copy link

@mixxael mixxael commented Mar 21, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (16f5062) to head (afa0aab).

Files with missing lines Patch % Lines
framework/helpers/BaseVarDumper.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20344   +/-   ##
=========================================
  Coverage     64.85%   64.85%           
  Complexity    11437    11437           
=========================================
  Files           431      431           
  Lines         37199    37199           
=========================================
  Hits          24125    24125           
  Misses        13074    13074           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xepozz
Copy link
Member

xepozz commented Mar 23, 2025

https://3v4l.org/gABFK
image

Looks valid

@xepozz
Copy link
Member

xepozz commented Mar 23, 2025

@mixxael could you also add a test?

<=8.2 – <br>
>=8.3 – \n

@samdark samdark added the pr:request for unit tests Unit tests are needed. label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:request for unit tests Unit tests are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants