Fix statcache in FileCache #20304
Merged
Fix statcache in FileCache #20304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20304 +/- ##
=========================================
Coverage 64.83% 64.83%
- Complexity 11417 11418 +1
=========================================
Files 431 431
Lines 37155 37158 +3
=========================================
+ Hits 24090 24092 +2
- Misses 13065 13066 +1 ☔ View full report in Codecov by Sentry. |
terabytesoftw
approved these changes
Dec 30, 2024
samdark
approved these changes
Dec 30, 2024
|
Thank you! |
samdark
reviewed
Dec 30, 2024
| @@ -155,7 +155,12 @@ protected function setValue($key, $value, $duration) | |||
| $duration = 31536000; // 1 year | |||
| } | |||
|
|
|||
| return @touch($cacheFile, $duration + time()); | |||
| if (@touch($cacheFile, $duration + time())) { | |||
| clearstatcache(); | |||
There was a problem hiding this comment.
We've ported it Yii3 cache and while doing so, decided that it's better to clear cache for that file only via clearstatcache(false, $cacheFile). Does that make sense to you?
There was a problem hiding this comment.
Stat cache is stored only for one (last) file, so I don't think you need to specify file path here. It is only used if you want to clear realpath cache, which is no needed here. So I don't think these changes make any sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20300