Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix chroot resolve null route #20160

Closed
wants to merge 2 commits into from
Closed

fix chroot resolve null route #20160

wants to merge 2 commits into from

Conversation

gozoro
Copy link

@gozoro gozoro commented May 16, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #20159

samdark
samdark reviewed May 16, 2024
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a line for CHANGELOG.

tests/framework/console/RequestTest.php
@@ -121,6 +121,16 @@ public function provider()
'-alias2=testValue',
],
],
],
[
// Case: Special argument "End of Options" placed insted route
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Case: Special argument "End of Options" placed insted route
// Case: Special argument "End of Options" placed instead of route

@gozoro
Copy link
Author

gozoro commented May 16, 2024

ooops my fork is old 2.0.16

@gozoro
Copy link
Author

gozoro commented May 16, 2024

I'm create new pull request

@gozoro gozoro closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gozoro @samdark