Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for altfield option when using inline-display mode for date… #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buttflattery
Copy link

…picker

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes/no
Fixed issues #87

@samdark samdark added this to the 2.0.8 milestone Jul 25, 2019
@samdark samdark added status:code review The pull request needs review. type:bug Bug pr:request for unit tests Unit tests are needed. and removed status:code review The pull request needs review. labels Jul 25, 2019
@yii-bot
Copy link

yii-bot commented Jul 25, 2019

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:request for unit tests Unit tests are needed. type:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants