Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not auto-login user when is verified #557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not auto-login user when is verified #557

wants to merge 1 commit into from

Conversation

mtangoo
Copy link

@mtangoo mtangoo commented Aug 15, 2023

Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues 556

@mtangoo mtangoo self-assigned this Aug 15, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 15, 2023

PR Summary

  • Removed Automatic Login After Email Verification
    The change involves the SiteController.php file, specifically in the actionVerifyEmail method. Previously, users were automatically logged in after their email verification, now this automatic feature has been eliminated. This is critical to ensure the control of user access and reinforce the need for users to manually log in after verifying their email addresses.

@mtangoo mtangoo requested a review from a team August 15, 2023 16:56
@mtangoo mtangoo mentioned this pull request Aug 15, 2023
Open
@machour
Copy link
Member

machour commented Aug 15, 2023 •
edited
Loading

@mtangoo you should update the VerifyEmailCest test to reflect the change of behavior before this PR gets considered 👀

@mtangoo
Copy link
Author

mtangoo commented Aug 15, 2023

Aye! @machour I do not even get how I missed such a basic thing :)
I will update it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtangoo mtangoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtangoo @machour